Merged
Conversation
Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com>
Contributor
Author
|
gazebosim/ros_gz#607 has been merged. |
Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com>
azeey
requested changes
Sep 26, 2024
Contributor
azeey
left a comment
azeey
left a comment
There was a problem hiding this comment.
Thanks for all the changes! There are some additional changes we're going to be making in ros_gz, so I don't think we'll be making a Jazzy release until then, so I suggest we keep the statements that say that the feature is only available in Rolling.
cc @caguero
Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com>
azeey
approved these changes
Sep 26, 2024
azeey
pushed a commit
to azeey/docs
that referenced
this pull request
Jan 9, 2025
* Switch to Jazzy Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com> * Update some files Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com> * Make Requested Changes Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com> --------- Signed-off-by: Aarav Gupta <134804732+Amronos@users.noreply.github.com> Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Switches Rolling references in various places to Jazzy for Harmonic.
To be merged after gazebosim/ros_gz#607 has been merged (and after Ionic is released?).
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.