-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port sensor update rate fix #3353
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Thanks for the forward port. What about the missing mutex lock? |
ah missed the note about mutex. Added. 82851d1 |
@peci1 does the fix looks ready for merge to you? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM!
Ok, I will leave some time for other people to comment, and then I will proceed to merge. Feel free to ping me if I forgot to merge. |
So, is 2 weeks a long enough incubation period? :) |
Even less, thanks for the ping! |
Sorry to comment on an old PR, but I must ask. Was the IMU provided by "GazeboRosImu" tested? Do other IMU plugins (custom made by third parties, like hector's IMU) need retrofiting? |
If you have a doubt on |
🦟 Bug fix
Summary
cherry-picked commit from #2863 to
gazebo11
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.