Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collada and Assimp test for default animation names #428

Closed
wants to merge 10 commits into from
Closed

Collada and Assimp test for default animation names #428

wants to merge 10 commits into from

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Aug 20, 2022 •
edited
Loading

🦟 Bug fix

Fixes #393

Summary

Checks default animation name assigned to collada and assimp loaded meshes. Requires #413 to assimp test to pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@onurtore onurtore requested a review from mjcarroll as a code owner August 20, 2022 09:42
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 20, 2022
@onurtore onurtore mentioned this pull request Aug 20, 2022
Open
8 tasks
@luca-della-vedova
Copy link
Member

luca-della-vedova commented Aug 22, 2022 •
edited
Loading

Should this be targeted to #413 instead of gz-common5 so the feature can be merged / tested together with its test?

@chapulina chapulina added bug Something isn't working tests Broken or missing tests / testing infra labels Aug 26, 2022
hidmic and others added 7 commits October 17, 2022 15:49
@hidmic @caguero
Add CSV data parsing (gazebosim#402)
10ff92c 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Co-authored-by: Carlos Agüero <cen.aguero@gmail.com>
@hidmic
Skip CSV header when reading DataFrame (gazebosim#435)
2d2f73c 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@arjo129 @mjcarroll @hidmic
Adds an API to retrieve keys. (gazebosim#446)
3bdeca4 
This is useful for when we perform visualization.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
@nkoenig
5.2.0 release (gazebosim#461)
5c74a63 
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Fix arm builds (gazebosim#462)
b3313c2 
* Fix arm builds

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Adding in pre-release 5.2.1

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Fix arm test (gazebosim#463)
1a26b9a 
* Fix arm test

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
5.2.1 release (gazebosim#464)
56b82ad 
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
@mjcarroll mjcarroll changed the base branch from gz-common5 to main October 26, 2022 15:16
hidmic and others added 3 commits October 26, 2022 22:24
@hidmic
Backport: Avoid Io.hh header name clash (gazebosim#472)
9521e1b 
Backports gazebosim#471 to Garden.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@mjcarroll
🎈 5.2.2 (gazebosim#473)
431a2ad 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@onurtore
Fix silly mistakes
4a61ca7 
Adds paranthesis

Signed-off-by: Onur Berk Töre <onurberk_t@hotmail.com>
@onurtore onurtore force-pushed the otore/animation_name branch from 20df9e2 to 4a61ca7 Compare November 10, 2022 05:44
@onurtore onurtore closed this Nov 10, 2022
@onurtore
Copy link
Contributor Author

onurtore commented Nov 10, 2022 •
edited
Loading

I messed this PR, so closing this and going to open a new one.

@onurtore
Copy link
Contributor Author

Opened #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@luca-della-vedova luca-della-vedova Awaiting requested review from luca-della-vedova

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
bug Something isn't working 🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@onurtore @luca-della-vedova @chapulina @hidmic @arjo129 @nkoenig @mjcarroll