Skip to content

Add bash completion #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2023
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 28, 2023

🎉 New feature

Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87

Summary

Bash completion for fuel tools

Test it

$ . install/share/bash-completion/completions/ign
$ ign fuel d<tab> 

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey self-assigned this Feb 28, 2023
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Feb 28, 2023
@azeey azeey marked this pull request as ready for review April 7, 2023 17:27
@azeey azeey requested a review from nkoenig as a code owner April 7, 2023 17:27
@azeey azeey requested a review from iche033 April 7, 2023 17:30
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@azeey
Copy link
Contributor Author

azeey commented Apr 25, 2023

@osrf-jenkins run tests please

azeey added 2 commits April 27, 2023 16:55
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #329 (8ce3e4e) into ign-fuel-tools4 (fe66f33) will not change coverage.
The diff coverage is n/a.

❗ Current head 8ce3e4e differs from pull request most recent head e228503. Consider uploading reports for the commit e228503 to get more accurate results

@@               Coverage Diff                @@
##           ign-fuel-tools4     #329   +/-   ##
================================================
  Coverage            77.72%   77.72%           
================================================
  Files                   19       19           
  Lines                 2766     2766           
================================================
  Hits                  2150     2150           
  Misses                 616      616           

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit e51c672 into gazebosim:ign-fuel-tools4 May 2, 2023
@azeey azeey deleted the bash_completion branch May 2, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants