Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 ➡️ main #423

Merged
merged 28 commits into from
Jun 6, 2024
Merged

9 ➡️ main #423

merged 28 commits into from
Jun 6, 2024

Conversation

Crola1702
Copy link
Contributor

➡️ Forward port

Port 9 to main

Branch comparison: main...9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey and others added 26 commits November 13, 2023 10:17
* Use on `push` only on stable branches to avoid duplicate runs
* Update project automation

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Use on `push` only on stable branches to avoid duplicate runs
* Update project automation

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Windows doesn't support colon or at-symbol in paths.
This disables the tests on gz-fuel-tools8, as we want to preserve the
behavior (to not invalidate anyone's current cache).  On gz-fuel-tools9
forward, the fix is implemented.

Do not forward port these changes

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge ign-fuel-tools4 ➡️  ign-fuel-tools7
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge ign-fuel-tools7 ➡️  gz-fuel-tools8
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…botics.org can be found in the cache (#406)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Use config.yaml file from default cache location, if it exists

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* support config.yml

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
* Add Private function to world identifier

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update include/gz/fuel_tools/WorldIdentifier.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Wrap line

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
* Cleanup curl pointer
* Do not duplicate version for gz_TEST
* curl_free missing for decodedPath
* Missing curl_free for encodedRes

---------

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…Noble) (#415)

* Migrate curl_formadd from form API to mime API

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

* Restore curl_easy_setopt call and use MIMEPOST

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

---------

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Co-authored-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@Crola1702 Crola1702 requested review from azeey and Blast545 May 30, 2024 15:12
@Crola1702 Crola1702 requested a review from nkoenig as a code owner May 30, 2024 15:12
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label May 30, 2024
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@azeey
Copy link
Contributor

azeey commented May 30, 2024

I can't merge because GitHub says "This branch cannot be rebased due to conflicts". Can you merge from main locally and push?

@Crola1702
Copy link
Contributor Author

I don't see any new changes from main, so I don't have anything else to push here 🤔

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually found a couple of issues. Maybe making those changes and pushing will fix the GitHub issue?

package.xml Outdated
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<name>gz-fuel_tools9</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<name>gz-fuel_tools9</name>
<name>gz-fuel_tools10</name>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed on: c991fc2

package.xml Outdated
<depend>gz-math8</depend>
<depend>gz-msgs11</depend>
<depend>gz-tools2</depend>
<depend>gz-utils2</depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<depend>gz-utils2</depend>
<depend>gz-utils3</depend>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed on: c991fc2

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested a review from azeey June 6, 2024 17:46
@azeey azeey merged commit c5bb55e into main Jun 6, 2024
7 checks passed
@azeey azeey deleted the Crola1702/9_to_main-30_05_2024 branch June 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants