-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash completion for flags #254
Conversation
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #254 +/- ##
==============================================
+ Coverage 12.93% 85.27% +72.33%
==============================================
Files 346 9 -337
Lines 60130 903 -59227
==============================================
- Hits 7779 770 -7009
+ Misses 52351 133 -52218 Continue to review full report at Codecov.
|
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pushed 385141e with some final tweaks:
- Always install CLI files, see Detect ign instead of using cmake module to check for ignition-tools #166 and [tracker] Remove ignition-tools cmake check in Ignition software gazebo-tooling/release-tools#472
- Link against filesystem to fix Bionic build
I think the debian metadata needs to be updated to install the new completion files
|
🎉 New feature
Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87
Summary
Bash completion, installation, tests.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.