Remove major version from package name#2726
Conversation
* Update cmake project name, package.xml name * Remove version from cmake target names * Change examples to find_package(gz-sim) and update target names. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Update tests and examples to import gz.sim Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
@osrf-jenkins run tests please |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
81082df to
1f21013
Compare
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
1f21013 to
9cfe829
Compare
|
I saw what looked like a flaky test, confirmed that it flakes locally, reported it in #2727, and restarted the job with the test failure |
|
I think gazebo-tooling/release-tools#1246 would fix the windows CI |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
gazebo-tooling/release-tools#1246 didn't fix the windows build:
I'll try something else |
|
@osrf-jenkins run tests please |
|
I manually configured the most recent job to run with gazebo-tooling/release-tools#1287 and it passed |
Companion to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Companion to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Companion to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
Works ! I mean I can run gz sim in the usual way. Not sure if it is under the scope of this first round of changes but we are still using the version in: The point for any all these is if we want to keep the version in the paths.
|
these changes are not directly user-facing for developers building with cmake (as opposed to writing compiler flags directly), so I skipped them we could choose to address them, but would likely need to update the debian metadata |
+1 |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
one other point is that at least some of this (maybe all) is configured in gz-cmake for example the |
|
There seems to be problem with the Model API on cli on Brew. If these are known or not related, I think we are good to merge. |
it only happens on certain CI machines; I think it is unrelated to this change, so I have already merged |
|
nightly build failed; I'll take a look at fixing the debian metadata: |
Follow-up to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
fixes for debian metadata in the following PRs: |
Companion to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Companion to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Follow-up to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Companion to gazebosim/gz-sim#2726. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
🎉 New feature
Part of gazebo-tooling/release-tools#1244.
Summary
This removes the major version from the package name in the following places:
find_packagecalls in examples and tutorialsimportstatements in tests, examples, and tutorialsTest it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.