Skip to content

Fix thread issue by adding check for invalid CLI combo #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XINJIANGMO wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Open

Fix thread issue by adding check for invalid CLI combo #3135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cccbef7
add check to avoid thread issue
XINJIANGMO Oct 18, 2025
3c3c240
update error message
XINJIANGMO Oct 18, 2025
01d1804
Merge branch 'main' into fixbug-3132
iche033 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cmd/sim_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,13 @@ int main(int argc, char** argv)

app.formatter(std::make_shared<GzFormatter>(&app));
CLI11_PARSE(app, argc, argv);

// check for invalid combination to avoid thread issue
if (!opt->file.empty() && !opt->playback.empty())
{
gzerr << "Both an SDF file and the playback flag (--playback) are specified. "
Copy link
Contributor

@iche033 iche033 Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue picked up by CI:

/github/workspace/src/cmd/sim_main.cc:467:  Lines should be <= 80 characters long

<< "Specify only one of these arguments." << std::endl;
return -1;
}
std::string parsedSdfFile;
if(!opt->launchServer && !opt->launchGui)
{
Expand Down
Loading