Update install.md with GPG key addition via trusted.gpg.d and add instructions to install Gazebo CMake from source #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructions to install Gazebo CMake from source Signed-off-by: Trushant Adeshara <150821956+trushant05@users.noreply.github.com>
github-actions
bot
added
🌱 garden
|
@j-rivero mind taking a look. Does this line up with the latest recommended installation instructions elsewhere? |
ahcorde
requested changes
Sep 6, 2024
tutorials/install.md
Outdated
| @@ -81,6 +86,14 @@ Gazebo Tools requires: | |||
|
|
|||
| * [Ruby](https://www.ruby-lang.org/). Refer to the [Ruby Documentation](https://www.ruby-lang.org/downloads/) for installation instructions. On Ubuntu systems `apt-get` can be used to install Ubuntu Package `ruby-dev`: | |||
|
|
|||
| Note: | |||
| In case the Gazebo CMake binary didn't work out for you, you can make it from source using following command: | |||
| ``` | |||
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```bash |
azeey
requested changes
Sep 9, 2024
Gazebo CMake is included as Prerequisites for building gz-tools from source. An additional note for the installation is removed since it was redundant. Signed-off-by: Trushant Adeshara <150821956+trushant05@users.noreply.github.com>
azeey
reviewed
Sep 11, 2024
tutorials/install.md
Outdated
| @@ -21,7 +21,12 @@ sudo sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `ls | |||
|
|
|||
| Setup keys: | |||
| ``` | |||
| wget http://packages.osrfoundation.org/gazebo.key -O - | sudo apt-key add - | |||
| wget -qO - http://packages.osrfoundation.org/gazebo.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/gazebo-archive-keyring.gpg > /dev/null | |||
There was a problem hiding this comment.
Other instructions, (example) use the following. I'd suggest we do that here as well for consistency.
sudo curl https://packages.osrfoundation.org/gazebo.gpg --output /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-stable $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/gazebo-stable.list > /dev/null
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Carlos Agüero <cen.aguero@gmail.com>
|
@trushant05, could you check Addisu's suggestion? |
@trushant05 , could you update the PR with Addisu's comments? |
|
@caguero apologies for the delay, I have updated the PR. Let me know if it requires additional modification. |
caguero
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Update install.md with GPG key addition via trusted.gpg.d and add instructions to install Gazebo CMake from source
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.