Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide cmake warning when Python3 Development is not found #565

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Unhide cmake warning when Python3 Development is not found #565

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d2491f
Unify Python3_Development_FOUND checks
scpeters Jan 9, 2025
e464330
try message(WARNING)
scpeters Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ else()
find_package(Python3
COMPONENTS Interpreter
OPTIONAL_COMPONENTS Development)
if (NOT Python3_Development_FOUND)
GZ_BUILD_WARNING("Python development libraries are missing: Python interfaces are disabled.")
endif()
endif()

#--------------------------------------
Expand Down Expand Up @@ -156,8 +153,12 @@ add_subdirectory(conf)
#============================================================================
# gz transport python bindings
#============================================================================
if (Python3_Development_FOUND AND NOT SKIP_PYBIND11)
add_subdirectory(python)
if (NOT SKIP_PYBIND11)
if (Python3_Development_FOUND)
add_subdirectory(python)
else ()
message(WARNING "Python development libraries are missing: Python interfaces are disabled.")
endif()
endif()

#============================================================================
Expand Down
Loading