Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review feedback from PR 1343 #1347

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Address review feedback from PR 1343 #1347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ if (BUILD_TESTING)
target_sources(library_for_tests PRIVATE ${urdf_internal_sources})
endif()

# Link against the publically and privately linked libraries of the core library
# Link against the publicly and privately linked libraries of the core library
target_link_libraries(library_for_tests
$<TARGET_PROPERTY:${PROJECT_LIBRARY_TARGET_NAME},LINK_LIBRARIES>
)
Expand All @@ -99,8 +99,6 @@ if (BUILD_TESTING)
${PROJECT_SOURCE_DIR}/test
LIB_DEPS
library_for_tests
TEST_LIST
test_targets
)

endif()
Expand Down
Loading