Use std::vector::reserve in Element::Clone #1480
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of #1478
Summary
The performance of
Element::Clone
is poor, as noted in #1478. This is a small change to attempt to improve memory allocation.There are several for-loops in
Element::Clone
that callstd::vector::push_back
, and since the vector size is known in advance, usestd::vector::reserve
to avoid multiple vector resizes.I ran the unit tests with this change, and I didn't observe any noticeable speed-up.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.