Skip to content

Add bazel deps to make sdformat work with bzlmod#1503

Closed
udaya2899 wants to merge 14 commits intogazebosim:sdf15from
udaya2899:sdf15
Closed

Add bazel deps to make sdformat work with bzlmod#1503
udaya2899 wants to merge 14 commits intogazebosim:sdf15from
udaya2899:sdf15

Conversation

@udaya2899
Copy link

@udaya2899 udaya2899 commented Nov 14, 2024

🦟 Bug fix

Summary

Added bazel deps to make it work with bzlmod. Tested locally with a local BCR following the guide.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Nov 14, 2024
udaya2899 and others added 11 commits November 14, 2024 16:05
Signed-off-by: Udaya Prakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: Udaya Prakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
…1492)

* Support removing the actor, light, or model from the root

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update src/Root_TEST.cc

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update src/Root_TEST.cc

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update src/Root_TEST.cc

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update src/Root_TEST.cc

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update src/Root_TEST.cc

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Update src/Root_TEST.cc

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
Signed-off-by: udayaprakash <udayaprakash@google.com>
@shameekganguly
Copy link
Contributor

@udaya2899 I think all of your changes were folded into @mjcarroll's #1507. So I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants