Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed spec version 1.12 in the sdf_descriptions target #1529

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add missed spec version 1.12 in the sdf_descriptions target #1529

merged 1 commit into from
Jan 15, 2025

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jan 15, 2025

🦟 Bug fix

Fixes #

Summary

This also updates the default versions in root.sdf files

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey
Add missed spec version 1.12 in the sdf_descriptions target
0a15bbb 
This also updates the default versions in root.sdf files

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner January 15, 2025 23:06
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Jan 15, 2025
@azeey azeey merged commit fd0292a into gazebosim:sdf15 Jan 15, 2025
16 checks passed
@azeey azeey deleted the fix_specs branch January 15, 2025 23:51
@azeey
Copy link
Collaborator Author

azeey commented Jan 21, 2025

@Mergifyio backport sdf14

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 21, 2025 •
edited
Loading

backport sdf14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 21, 2025
@azeey @mergify
Add missed spec version 1.12 in the sdf_descriptions target (#1529)
fd02133 
This also updates the default versions in root.sdf files

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
(cherry picked from commit fd0292a)

# Conflicts:
#	sdf/1.12/root.sdf
@mergify mergify bot mentioned this pull request Jan 21, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azeey @ahcorde @scpeters