fix: stabilize iOS mobile keyboard controls #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a DebugOverlay component for UI debugging, activated via the 'debug-ui' query param. Improves visual viewport and keyboard inset handling by tracking additional metrics (offsets, viewport size), updating related CSS variables, and refining polling and event logic in useVisualViewport. Updates tests and styles to support new debug and viewport features, and improves keyboard visibility detection in Terminal.
Refines keyboard visibility logic by using isKeyboardVisible in Terminal and updates keyboard height calculation to consider document height. Adds orientation change handling in useVisualViewport and updates related tests. Also sets position and z-index for terminal controls in CSS.
Replace the constant 250ms basePollTimer on iOS with a longer RAF burst duration (800ms → 1500ms) during focus/orientation changes. This should still catch keyboard animations while reducing unnecessary polling when the keyboard is hidden. Remaining update mechanisms: - RAF burst (1500ms) on focus/orientation change - pollTimer (250ms) while text input is focused - Event listeners for resize, scroll, focus changes Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--viewport-offset-top,--viewport-offset-left,--visual-viewport-height,--visual-viewport-width)position: fixedwithbottomto height-based layout for better iOS PWA compatibilityisKeyboardVisibledetection in Terminal to handle edge casesTest plan
🤖 Generated with Claude Code