Skip to content

Fix shared-components test to use correct JSON field names #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbasin merged 1 commit into from
Dec 25, 2025
Merged

Fix shared-components test to use correct JSON field names #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/e2e/shared-components.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,12 @@ describe('Shared + Validate Integration', () => {
const validateData = JSON.parse(validateResult);

// Should report the unique element as missing (critical)
expect(validateData.critical_missing).toBe(1);
// The script outputs total_critical_missing at root level for multi-file support
expect(validateData.total_critical_missing).toBe(1);

// Should NOT include the shared exit button instances in missing
const missingIds = validateData.missing?.map((m: { id: string }) => m.id) || [];
// Missing IDs are nested under files[0].missing for multi-file support
const missingIds = validateData.files?.[0]?.missing?.map((m: { id: string }) => m.id) || [];
expect(missingIds).not.toContain('I237:2417;2708:1961');
expect(missingIds).not.toContain('I237:2572;2708:1961');

Expand Down