Add DocBoy emulator. Run ax6 roms on DMG too.#26
Open
Docheinstein wants to merge 5 commits intogbdev:mainfrom
Open
Add DocBoy emulator. Run ax6 roms on DMG too.#26Docheinstein wants to merge 5 commits intogbdev:mainfrom
Docheinstein wants to merge 5 commits intogbdev:mainfrom
Conversation
The Extract-7Zip command is not supported anymore by GitHub actions. It has been replaced with the Expand-7ZipArchive. Source: actions/runner-images#9361 (comment)
The distutils package has been removed with Python 3.12 (that is the Python version run by the GitHub actions at the moment). We were using it for distutils.dir_util.copy_tree, which has been replaced with shutil.copytree. Source: https://docs.python.org/3.11/whatsnew/3.10.html#distutils-deprecated
ax6's RTC tests do not actually need CGB; DMG is fully capable of run these roms. Therefore, the CGB requirement has been removed and the screenshots of such roms have been updated with the DMG's one.
Author
|
I guess the workflow failed because I don't have the permissions/I am not a contributor?? By the way, feel free to tell me if there's something of this PR I could improve or change. |
Open
Contributor
|
I'm going to work on this in a bit once I get the other emulators updated. |
avivace
requested changes
Mar 20, 2026
Member
avivace
left a comment
avivace
left a comment
There was a problem hiding this comment.
The changes related to DocBoy seem ok to me but:
- ax6 test roms results are updated (?)
- there are some unrelated changes in the ares emulator and in the main pipeline
| Start-Service audio* | ||
| Invoke-WebRequest https://github.com/duncanthrax/scream/releases/download/3.6/Scream3.6.zip -OutFile C:\Scream3.6.zip | ||
| Extract-7Zip -Path C:\Scream3.6.zip -DestinationPath C:\Scream | ||
| Expand-7ZipArchive -Path C:\Scream3.6.zip -DestinationPath C:\Scream |
| import PIL.Image | ||
| import PIL.ImageOps | ||
| from distutils.dir_util import copy_tree | ||
| from shutil import copytree |
|
|
||
| if not os.path.exists("emu/ares/ares.exe"): | ||
| copy_tree(os.path.join("emu/ares", os.listdir("emu/ares")[0]), "emu/ares") | ||
| copytree(os.path.join("emu/ares", os.listdir("emu/ares")[0]), "emu/ares") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR:
As a consequence, this PR also update usages of Windows commands and Python packages that are not supported yet by the GitHub actions.
Commits:
Closes #24.
Closes #25.