Add MASK_EN note #629
Open
Add MASK_EN note #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close gbdev#625
avivace
requested changes
Oct 2, 2025
avivace
approved these changes
Oct 2, 2025
|
Wait, really? I thought only another |
|
Maybe it needs clarification. If the screen was frozen by clearing LCDC, it will be unfrozen when its bit 7 is set. |
|
Ah, I see: it's another freezing mechanism, separate from |
|
Yes. Enlightened by beware. |
ISSOtm
requested changes
Oct 4, 2025
Comment on lines
+29
to
+30
| SGB freezes/unfreezes the Game Boy screen automatically whenever the LCD is | ||
| turned off/on. |
There was a problem hiding this comment.
Suggested change
| SGB freezes/unfreezes the Game Boy screen automatically whenever the LCD is | |
| turned off/on. | |
| The screen retains its last frame when the "LCD" is [turned off](<#LCDC.7 — LCD enable>), though it gets blanked out after a while. |
There was a problem hiding this comment.
I think "stops updating" might confuse people, although it's technically correct.
I'm not sure what "gets blanked out after a while" means.
There was a problem hiding this comment.
AFAIK, leaving the screen turned off for a significant period of time causes the SGB firmware to blank out the framebuffer.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #625