Prefer empty braces to semicolons for empty loop bodies

gbdev · Jan 17, 2025 · fac5e35 · fac5e35
1 parent a85d6b3
commit fac5e35
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/src/asm/charmap.cpp b/src/asm/charmap.cpp
@@ -168,8 +168,7 @@ bool charmap_HasChar(std::string const &input) {
 
 std::vector<int32_t> charmap_Convert(std::string const &input) {
 	std::vector<int32_t> output;
-	for (std::string_view inputView = input; charmap_ConvertNext(inputView, &output);)
-		;
+	for (std::string_view inputView = input; charmap_ConvertNext(inputView, &output);) {}
 	return output;
 }
 

diff --git a/src/asm/parser.y b/src/asm/parser.y
@@ -2577,8 +2577,7 @@ static size_t charlenUTF8(std::string const &str) {
 	std::string_view view = str;
 	size_t len;
 
-	for (len = 0; charmap_ConvertNext(view, nullptr); len++)
-		;
+	for (len = 0; charmap_ConvertNext(view, nullptr); len++) {}
 
 	return len;
 }

diff --git a/src/link/patch.cpp b/src/link/patch.cpp
@@ -250,8 +250,7 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
 			// `expression` is not guaranteed to be '\0'-terminated. If it is not,
 			// `getRPNByte` will have a fatal internal error.
 			char const *name = reinterpret_cast<char const *>(expression);
-			while (getRPNByte(expression, size, patch))
-				;
+			while (getRPNByte(expression, size, patch)) {}
 
 			if (Section const *sect = sect_GetSection(name); !sect) {
 				error(
@@ -281,8 +280,7 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
 		case RPN_SIZEOF_SECT: {
 			// This has assumptions commented in the `RPN_BANK_SECT` case above.
 			char const *name = reinterpret_cast<char const *>(expression);
-			while (getRPNByte(expression, size, patch))
-				;
+			while (getRPNByte(expression, size, patch)) {}
 
 			if (Section const *sect = sect_GetSection(name); !sect) {
 				error(
@@ -302,8 +300,7 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
 		case RPN_STARTOF_SECT: {
 			// This has assumptions commented in the `RPN_BANK_SECT` case above.
 			char const *name = reinterpret_cast<char const *>(expression);
-			while (getRPNByte(expression, size, patch))
-				;
+			while (getRPNByte(expression, size, patch)) {}
 
 			if (Section const *sect = sect_GetSection(name); !sect) {
 				error(