Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 99999 macro arg limit #1597

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jan 4, 2025

This limit was never documented, and was basically a convenience in C because allocating memory for all those args was handled manually. Now they're just in a std::vector, and this check feels more like cruft than an actual safety mechanism.

(It's possible for a vector to OOM, of course, but we have plenty of other places that risk that. The parser has many values which unboundedly build up a vector, like charmap multi-values, purged symbols, or ds N, ... expressions. Nobody is actually ever going to get near the machine limits.)

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Jan 4, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 4, 2025
@Rangi42 Rangi42 requested review from ISSOtm and removed request for ISSOtm January 4, 2025 02:11
@Rangi42 Rangi42 merged commit d829fd2 into gbdev:master Jan 4, 2025
23 checks passed
@Rangi42 Rangi42 deleted the max-macro-args branch January 4, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant