Add "readable" option to hide unreadable files#35
Open
PacAnimal wants to merge 3 commits intogburca:masterfrom
Open
Add "readable" option to hide unreadable files#35PacAnimal wants to merge 3 commits intogburca:masterfrom
PacAnimal wants to merge 3 commits intogburca:masterfrom
Conversation
Append a slash on directories, to be able to match them separately from files.
gburca
reviewed
Jun 17, 2020
Owner
gburca
left a comment
gburca
left a comment
There was a problem hiding this comment.
Thank you for the patch. Looks good. Can you rename readable to hide_unreadable (with underscore and dash as appropriate) so the effect of the option is more obvious.
| log_msg(LOG_DEBUG, "should_hide: %s %07o", name, mode); | ||
| log_msg(LOG_DEBUG, "should_hide: %s %07o", path, mode); | ||
| if (conf.readable) { | ||
| char *trpath=translate_path(path); |
Owner
There was a problem hiding this comment.
spaces missing around assignment operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using rofs as a filter, I decided to add an option to filter out unreadable files, such as dead symlinks and things you don't have permission to access on a remote file share.
I use this to filter a mounted share from a Windows machine, so the backup software the Linux box uses doesn't generate hundreds of errors for all the files the Windows user can see but can't access.
I also cleaned up some whitespace, and renamed the "name" variable to "path", as that's what's commonly passed to it.
Thought it might be useful for others, too.