chore: Create GitHub workflow to replace Netlify workflow #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\r\nhttps://covid-19-guidance.tbs.alpha.canada.ca/.github/workflows/test.html |
delisma
force-pushed
the
feature/workflow
branch
from
092650c to
6ae5872
Compare
chore: Create new GitHub workflow based on Netlify workflow chore: Update preview-html.yml chore: Update preview-html.yml chore: Update preview-html.yml chore: Update preview-html.yml chore: Update covid-19-guidance-ingress.yaml doc: Update index.html style: Update preview-html.yml style: Update index.html style: Update preview-html.yml style: Update preview-html.yml style: Update preview-html.yml style: Update index.html style: Update preview-html.yml style: Update preview-html.yml style: Update preview-html.yml style: Update preview-html.yml style: Update index.html style: Update preview-html style: Created parse-file-array.sh
delisma
force-pushed
the
feature/workflow
branch
from
6ae5872 to
cb94336
Compare
delisma
force-pushed
the
feature/workflow
branch
3 times, most recently
from
2ac6ddc to
9822324
Compare
delisma
force-pushed
the
feature/workflow
branch
from
9822324 to
7f03fdb
Compare
delisma
force-pushed
the
feature/workflow
branch
from
7f03fdb to
a3ed0c5
Compare
delisma
force-pushed
the
feature/workflow
branch
from
a3ed0c5 to
326fc4a
Compare
delisma
force-pushed
the
feature/workflow
branch
from
326fc4a to
ebb1836
Compare
delisma
force-pushed
the
feature/workflow
branch
from
ebb1836 to
ad1896b
Compare
delisma
force-pushed
the
feature/workflow
branch
from
ad1896b to
691ea17
Compare
delisma
force-pushed
the
feature/workflow
branch
from
691ea17 to
14cacd9
Compare
delisma
force-pushed
the
feature/workflow
branch
3 times, most recently
from
ea77eed to
eac955b
Compare
delisma
force-pushed
the
feature/workflow
branch
4 times, most recently
from
56031ee to
24e2dec
Compare
delisma
force-pushed
the
feature/workflow
branch
from
24e2dec to
0c6518e
Compare
nschonni
reviewed
Oct 15, 2020
| @@ -1,35 +1,33 @@ | |||
| name: Preview HTML on Pull Requests | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
If you want this to run of PRs from forks, you might need to use pull_request_target https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
Downside is that changes don't run till they land in the default branch
| # echo ${{ env.LINKS }} | ||
|
|
||
| # Create comment in the PR with the urls of the changed files | ||
| - name: Update status to Waiting for approval |
There was a problem hiding this comment.
Aside: you might want to check this out if you want to only have one comment on the PR that gets updated https://github.com/w3c/aria-practices/blob/78bb9a05a39a1fdfe5971d692e149cf65ae93780/.github/workflows/coverage-report.yml#L26
delisma
force-pushed
the
master
branch
4 times, most recently
from
83739a1 to
7152ad3
Compare
delisma
force-pushed
the
master
branch
3 times, most recently
from
5ff1f18 to
d637536
Compare
delisma
force-pushed
the
master
branch
10 times, most recently
from
47b1ebf to
f5649c0
Compare
delisma
force-pushed
the
master
branch
2 times, most recently
from
f6e8d1e to
d5449ae
Compare
delisma
force-pushed
the
master
branch
3 times, most recently
from
3bcf589 to
bc6f453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.