Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Clean Code and S.O.L.I.D #4

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

DanMke
Copy link
Member

@DanMke DanMke commented Nov 26, 2020

Proposed changes

clean code application focused on avoiding duplication and distribution of responsibilities for applying the Single Responsibility Principle

Issue(s)

There is no specific issue

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre and others added 12 commits November 12, 2020 11:07
…2636)

* Fix parent title on thread header breaking lines

* Fix RocketChat#2519

* Fix thread badge not being updated
* Add hitSlop to RoomView header

* Use 1 icon padding for threads header

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
* Fixes RocketChat#2625

* Fixes RocketChat#2614

* Apply resValue on defaultConfig and undo unnecessary changes

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
* [FIX] Jitsi users being muted always

* fix: bundle is invalid

* Update jitsi meet sdk with ui improvements

* Update JitsiMeetSDK ios

* Centralize toolbox android

* Fix images on Jitsi

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Signed-off-by: Daniel Maike <danmke@hotmail.com>
@DanMke DanMke self-assigned this Nov 26, 2020
@DanMke DanMke changed the title Refactor.clean code and solid Refactor - Clean Code and S.O.L.I.D Nov 26, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants