-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leuber bug 246/247 #322
Merged
Merged
Leuber bug 246/247 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug to indicate that the likes limit has been reached
Added a test to cover if a user has no likes remaining
Fixed bug to indicate that the likes limit has been reached
Added a test to cover if a user has no likes remaining
Added css styling for the modal pop-up
Eliminated the option to change username
Modified accountview tests. Eliminated tests that test changing the username
removed reset_likes_view since it is not needed
Removed ResetLikesViewTest
Commented out. Not used
Commented out. Not used
AndresZarta
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This looks correct to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed Bug #246. When a user tries to exceed their likes limit, the following message is displayed:
Also, I added an additional unit test to cover this
I also fixed Bug #247. A pop-up window is now displayed that indicates the password change status
Lastly, I removed the option to change the username. I updated the template and corresponding tests as well.