Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leuber bug 246/247 #322

Merged
merged 31 commits into from
Dec 6, 2023
Merged

Leuber bug 246/247 #322

merged 31 commits into from
Dec 6, 2023

Conversation

ll4407
Copy link
Contributor

@ll4407 ll4407 commented Dec 5, 2023

I fixed Bug #246. When a user tries to exceed their likes limit, the following message is displayed:
Screenshot 2023-12-05 at 10 55 39 AM

Also, I added an additional unit test to cover this

I also fixed Bug #247. A pop-up window is now displayed that indicates the password change status

Screenshot 2023-12-05 at 10 53 15 AM Screenshot 2023-12-05 at 10 53 22 AM

Lastly, I removed the option to change the username. I updated the template and corresponding tests as well.

ll4407 added 30 commits December 5, 2023 05:35
Fixed bug to indicate that the likes limit has been reached
Added a test to cover if a user has no likes remaining
Fixed bug to indicate that the likes limit has been reached
Added a test to cover if a user has no likes remaining
Added css styling for the modal pop-up
Eliminated the option to change username
Modified accountview tests.  Eliminated tests that test changing the username
removed reset_likes_view since it is not needed
Removed ResetLikesViewTest
Commented out.  Not used
Commented out.  Not used
Copy link
Contributor

@AndresZarta AndresZarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks correct to me!

@AndresZarta AndresZarta merged commit fd4d511 into develop Dec 6, 2023
4 checks passed
@ll4407 ll4407 deleted the Leuber-Bug-246/247 branch December 6, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants