Voyager 3D support for *glb files #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pre-Dataverse 6.4 (which doesn't recognize the *.glb files, one can edit the Accept header in the voyager-explorer.min.js script to accept * in addition to text/plain (there is only one place this happens in their current script so easy to find). 6.4, in addition to adding the mimetype, changes the file download api to @produce */* (making text/plain an OK request rather than a 406 error).
|
Merging to support testing with github.io version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Smithsonian Voyager app as a previewer.
Closes #57
Note: to accomplish this I had to edit the Voyager minimized js. Specifically, the app appeared to try to retrieve the *.glb file as text/plain and our code considers that request un-supportable. For now, I change the Accept header to "text/plain, *". It is possible that Voyager could/should fix this. (I haven't yet submitted any issue to their repo).
Also note that the Smithsonian Voyager viewer can view other file types and some of those will be more difficult to support. For example, there is one type where the viewer reads a json file that is expected to have relative paths to other required files. In Dataverse, these relative paths are wrong, aren't signed, etc. so dynamically rewriting that file or adapting the app (it's open source) might be needed.