🔧 Fix multiple ports bug #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
|
Actually maybe I need to think how to approach this given the tests |
daquintero
force-pushed
the
dario/fix_recursive_e_netlist
branch
3 times, most recently
from
b519aeb
to
8bf7898
Compare
daquintero
force-pushed
the
dario/fix_recursive_e_netlist
branch
from
8bf7898
to
ca395cc
Compare
|
Hi @joamatab , I think this will fix it and make it compatible to the previous release since the previous tests are now passing! What do you think? Works for me in piel I think. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Awesome! thank you Dario! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I actually fixed this bug a few months ago but forgot to open PR. Currently stabilising the the piel simulation API in piel before migrating to gdsfactory 8. It'd be great to do a final release with gdsfactory7 and this is the only bug on the full flows. Not sure if a patch release gdsfactory7 is possible before migrating piel to gdsfactory8