better serialization

[joamatab]

• drop None from get_netlist. This avoids a lot of warnings in sax

@flaport

[sourcery-ai]

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

[thomaslima]

@joamatab @tvt173 Is this a permanent change? It messed with my tests - and I'd rather record the null arguments in the settings dictionary.

[tvt173]

hi @thomaslima , it seems to persist in gdsfactory8
https://github.com/gdsfactory/gdsfactory/blob/b652fde4b09203d3b0d92cada2809f14c3dd6e35/gdsfactory/get_netlist.py#L195

however, i'm not fully aware of the details on why this change was made, other than what is stated in this issue. we used to have an option in this function to let you toggle that behavior (record full settings vs. only non-default).
@joamatab @flaport what are your thoughts on this?

[joamatab]

this change is required when netlisting components that have references that are not registered in the PDK

I found 3 ways of fixing this:

• flatten imported GDS (slow and big sizes)
• extract full GDS subcells and register them in PDK (complex)
• Ignore those components from netlist extraction

We did a similar PR on gdsfactory8 recently

@nikosavola
@sebastian-goeldi

[thomaslima]

Thanks everyone for the explanation. I have to say I don't understand the reasons because I don't use sax (yet). But what does the netlist parameters have to do with components not registered in PDK? Should I worry about that too?

…

On Thu, Aug 22, 2024 at 7:20 PM Joaquin Matres ***@***.***> wrote: this change is required when netlisting components that have references that are not registered in the PDK I found 3 ways of fixing this: - flatten imported GDS (slow and big sizes) - extract full GDS subcells and register them in PDK (complex) - Ignore those components from netlist extraction We did a similar PR on gdsfactory8 recently @nikosavola <https://github.com/nikosavola> @sebastian-goeldi <https://github.com/sebastian-goeldi> — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIJZE52EV6LQNVPCWYJE63ZSZW45AVCNFSM6AAAAABIPJGLBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVHEYDKNBSGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>