Merge pull request #144 from gdsfactory/143-keep_mirror-in-add_ports-…

…is-not-always-set-properly fixed keep_mirror flag for add_port
gdsfactory · Jun 1, 2023 · 9e1b748 · 9e1b748
2 parents 91f217c + 4030a74
commit 9e1b748
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 6 deletions.
diff --git a/changelog.d/143.fixed.md b/changelog.d/143.fixed.md
@@ -0,0 +1 @@
+Fixed add_port ignore keep_mirror flag
diff --git a/src/kfactory/kcell.py b/src/kfactory/kcell.py
@@ -998,7 +998,7 @@ def add_port(
         """
         if self._locked:
             raise LockedError(self)
-        self.ports.add_port(port=port, name=name)
+        self.ports.add_port(port=port, name=name, keep_mirror=keep_mirror)
 
     def add_ports(
         self, ports: Iterable[Port], prefix: str = "", keep_mirror: bool = False
@@ -2243,10 +2243,10 @@ def add_port(
         """
         _port = port.copy()
         if not keep_mirror:
-            if port._trans:
-                port._trans.mirror = False
-            elif port._dcplx_trans:
-                port._dcplx_trans.mirror = False
+            if _port._trans:
+                _port._trans.mirror = False
+            elif _port._dcplx_trans:
+                _port._dcplx_trans.mirror = False
         if name is not None:
             _port.name = name
         self._ports.append(_port)
@@ -2257,7 +2257,7 @@ def add_ports(
         """Append a list of ports."""
         for p in ports:
             name = p.name or ""
-            self.add_port(port=p, name=prefix + name)
+            self.add_port(port=p, name=prefix + name, keep_mirror=keep_mirror)
 
     @overload
     def create_port(

diff --git a/tests/test_ports.py b/tests/test_ports.py
@@ -100,3 +100,41 @@ def test_connect_integer(wg):
     wg2.connect("o1", wg1, "o1")
 
     assert wg2.ports["o1"].trans == kf.kdb.Trans(0, False, 0, 0)
+
+
+def test_keep_mirror(LAYER):
+    c = kf.KCell()
+
+    p1 = kf.Port(trans=kf.kdb.Trans.M90, width=1000, layer=LAYER.WG)
+
+    c.add_port(p1, name="o1")
+    c.add_port(p1, name="o2", keep_mirror=True)
+
+    assert c["o1"].trans.is_mirror() is False
+    assert c["o2"].trans.is_mirror() is True
+
+
+def test_addports_keep_mirror(LAYER):
+    c = kf.KCell()
+
+    ports = [
+        kf.Port(
+            name=f"{i}",
+            width=1000,
+            layer=LAYER.WG,
+            trans=kf.kdb.Trans(i, True, 0, 0),
+        )
+        for i in range(4)
+    ]
+
+    c.add_ports(ports, prefix="mirr_", keep_mirror=True)
+    c.add_ports(ports, prefix="nomirr_", keep_mirror=False)
+
+    for i in range(4):
+        t1 = c[f"mirr_{i}"].trans
+        t2 = c[f"nomirr_{i}"].trans
+
+        t2_mirr = t2.dup()
+        t2_mirr.mirror = not t2_mirr.is_mirror()
+
+        assert t1 == t2_mirr