exec: fix debug handler #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
force-pushed
the
fix-debug-handler
branch
from
519b003
to
b6b20ce
Compare
For the exec plugin, we were writing debug output even when the user had not called `gdtcontext.WithDebug()`. In addition, stdout and stderr contents were only being written to debug writers when executed during `on.fail.exec`. These two problems are fixed in this commit in addition to correcting an erroneous `$LOCATION` in the README.md that needed to be `$$LOCATION`. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
force-pushed
the
fix-debug-handler
branch
from
b6b20ce
to
22000f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the exec plugin, we were writing debug output even when the user had not called
gdtcontext.WithDebug(). In addition, stdout and stderr contents were only being written to debug writers when executed duringon.fail.exec. These two problems are fixed in this commit in addition to correcting an erroneous$LOCATIONin the README.md that needed to be$$LOCATION.