fix nest SignedAttestation.Message per devnet-1 spec#64
Open
bomanaps wants to merge 1 commit intogeanlabs:mainfrom
Open
fix nest SignedAttestation.Message per devnet-1 spec#64bomanaps wants to merge 1 commit intogeanlabs:mainfrom
bomanaps wants to merge 1 commit intogeanlabs:mainfrom
Conversation
Author
|
But please go through this carefully @devylongs @mananuf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed SignedAttestation from a flattened structure (ValidatorID, Message: *AttestationData) to a nested structure (Message: *Attestation) to match the SSZ container definition in leanSpec this ensures correct hash tree root computation for signature verification and interoperability with other devnet-1 clients.
Spec reference: leanSpec@050fa4a:src/lean_spec/subspecs/containers/attestation/attestation.py lines 38-44
(Sorry for naming this branch devnet2 - these changes are for devnet-1 compliance.)