refactor(xmss): reduce duplication in leansig FFI layer#69
Open
Itodo-S wants to merge 3 commits intogeanlabs:mainfrom
Open
refactor(xmss): reduce duplication in leansig FFI layer#69Itodo-S wants to merge 3 commits intogeanlabs:mainfrom
Itodo-S wants to merge 3 commits intogeanlabs:mainfrom
Conversation
…reduce-duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates repeated boilerplate in the XMSS leansig bindings, both the Rust FFI library and the Go CGo layer, by extracting shared patterns into reusable helpers. Also bumps the genesis time in
config.yaml.Why
Both
leansig-ffi/src/lib.rsandleansig/leansig.gohad the same structural patterns repeated verbatim across multiple functions. The Rust match-on-deserialization pattern appeared 5 times, and the Go result-code-to-error mapping was duplicated identically inVerifyandVerifyWithKeypair. This made the code harder to maintain and obscured the actual logic.What Changed
xmss/leansig-ffi/src/lib.rstry_deserialize!macro that handles thematch/Err(_) => return LeansigResult::DeserializationFailedpattern uniformlymatchblocks inleansig_keypair_restore,leansig_verify, andleansig_verify_with_keypairwith macro invocationsxmss/leansig/leansig.goverifyResulthelper that maps aC.LeansigResultcode to a Go errorif/if/returnerror translation in both Verify andVerifyWithKeypairinto a singlereturn verifyResult(...)call