Builders: Ensure /etc/mtab is available on Docker mingw64 image build #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the image with BuildKit (which is enabled by default in newer Docker versions), /etc/mtab is not created automatically anymore. Since Pacman relies on it, we create the file if necessary.
eht16
force-pushed
the
ci_builders_create_mtab
branch
from
52a5e88 to
f8e81de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some weeks, building the image on Github Runners fails because during image build the file
/etc/mtabis not present in the build container.After some research, I noticed this file is created automatically when building with Docker without BuildKit. Once BuildKit is enabled, this file is not created automatically anymore.
Note, this is independent from running the container image. There the file is always created.
The Github runners were probably upgraded some time in the last weeks and currently they are running Docker 24 which enables BuildKit by default.
On older Docker installations, this can be reproduced by setting
DOCKER_BUILDKIT=1.I didn't find any reference on why the file is not created anymore when using BuildKit. It's probably no issue for most image builds. In our case, we use the Pacman package manager which relies on
/etc/mtab.Therefore, we simply create the file (as symlink to
/proc/mounts) if it doesn't exist yet.