Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipywidgets dark mode for toolbar buttons on Colab #1716

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix ipywidgets dark mode for toolbar buttons on Colab #1716

merged 2 commits into from
Sep 21, 2023

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented Sep 19, 2023

Fix #1715

@giswqs giswqs requested review from jdbcode and naschmitz September 19, 2023 19:55
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

@github-actions github-actions bot temporarily deployed to pull request September 19, 2023 20:03 Inactive
@naschmitz
Copy link
Collaborator

Would you be able to update the PR title to indicate this fixes dark mode for toolbar buttons? There are other dark mode bugs as well that this PR doesn't address (i.e. font color on inspector, etc.).

@giswqs giswqs changed the title Fix ipywidgets dark mode on Colab Fix ipywidgets dark mode for toolbar buttons on Colab Sep 19, 2023
@giswqs
Copy link
Member Author

giswqs commented Sep 19, 2023

Title updated. I don't have a solution for fixing the text color issue yet. Still exploring

@giswqs giswqs merged commit c509c97 into master Sep 21, 2023
13 checks passed
@giswqs giswqs deleted the colab branch September 21, 2023 16:22
@github-actions github-actions bot temporarily deployed to pull request September 21, 2023 16:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode on Google Colab
2 participants