Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LitElement logic out into a superclass #2166

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Refactor LitElement logic out into a superclass #2166

merged 1 commit into from
Nov 8, 2024

Conversation

naschmitz
Copy link
Collaborator

Move LitElement-specific logic into an abstract superclass to reduce the boilerplate code for new LitElement anywidgets. This superclass handles:

  • subscribing to model changes and updating the corresponding LitElement properties, and
  • propagating LitElement property updates to the model.

@naschmitz naschmitz added the refactor Used for code refactors label Nov 7, 2024
sufyanAbbasi
sufyanAbbasi approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@sufyanAbbasi sufyanAbbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! LGTM!

@naschmitz naschmitz merged commit b2c3f0c into gee-community:master Nov 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sufyanAbbasi sufyanAbbasi sufyanAbbasi approved these changes

@giswqs giswqs Awaiting requested review from giswqs

Assignees
No one assigned
Labels
refactor Used for code refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naschmitz @sufyanAbbasi