switched removing obsolete packages to variable #472 #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmyatt
reviewed
Jun 9, 2025
| @@ -17,6 +17,11 @@ | |||
| update_cache: true | |||
| when: docker_add_repo | bool | |||
|
|
|||
| - name: Set obselete packages if not already defined | |||
jamesmyatt
reviewed
Jun 9, 2025
| @@ -39,8 +45,10 @@ docker_obsolete_packages: | |||
| - containerd | |||
| - runc | |||
| ``` | |||
There was a problem hiding this comment.
Needs blank line after code block
jamesmyatt
reviewed
Jun 9, 2025
|
|
||
| A list of packages to be uninstalled prior to running this role. See [Docker's installation instructions](https://docs.docker.com/engine/install/debian/#uninstall-old-versions) for an up-to-date list of old packages that should be removed. | ||
| A list of packaged to be uninstalled on RedHat based systems prior to running this role. See [Docker's installation instructions](https://docs.docker.com/engine/install/rhel/#uninstall-old-versions) for an up-to-date list of old packages that should be removed. |
jamesmyatt
reviewed
Jun 9, 2025
| @@ -39,8 +45,10 @@ docker_obsolete_packages: | |||
| - containerd | |||
| - runc | |||
| ``` | |||
| A list of packages to be uninstalled on Debian based systems prior to running this role. See [Docker's installation instructions](https://docs.docker.com/engine/install/debian/#uninstall-old-versions) for an up-to-date list of old packages that should be removed. | |||
There was a problem hiding this comment.
The description should be consistently before or after the variable yaml.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I have no clue what that AI agent thing is doing, but it does not add anything but noise to the process of trying to get a PR merged. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I'm closing this PR since the issue no longer occurs on the latest version of this role in Fedora |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows redhat users to specify obsolete packages to work around issue #472