Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loggers configuration #278

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Add loggers configuration #278

merged 4 commits into from
Feb 12, 2024

Conversation

geirolz
Copy link
Owner

@geirolz geirolz commented Feb 12, 2024

Resolve #273

@geirolz geirolz self-assigned this Feb 12, 2024
case "slf4j" => Slf4j
case "log4j2" => Log4j2
case "apache-commons" => ApacheCommons
case custom => Custom(custom)

Check notice

Code scanning / Codacy-scalameta-pro (reported by Codacy)

Prohibit case statement pattern match from being lowercase. Note

Lower case pattern matching.
@@ -63,6 +63,7 @@
val defaultDefaultSchemaName: Option[String] = None
val defaultSchemaNames: Option[NonEmptyList[String]] = None
val defaultLockRetryCount: Int = 50
val defaultLoggers: List[LoggerType] = List(LoggerType.Auto)

Check notice

Code scanning / Scalastyle (reported by Codacy)

Field name does not match the regular expression '^[A-Z][A-Za-z0-9]*$'. Note

Field name does not match the regular expression '^[A-Z][A-Za-z0-9]*$'.
@@ -0,0 +1,30 @@
package fly4s.data

Check notice

Code scanning / Scalastyle (reported by Codacy)

File must not end with newline character. Note

File must not end with newline character.
case "slf4j" => Slf4j
case "log4j2" => Log4j2
case "apache-commons" => ApacheCommons
case custom => Custom(custom)

Check notice

Code scanning / Scalastyle (reported by Codacy)

Lowercase pattern match (surround with ``, or add : Any). Note

Lowercase pattern match (surround with ``, or add : Any).
@@ -0,0 +1,30 @@
package fly4s.data

Check notice

Code scanning / Scalastyle (reported by Codacy)

Header does not match expected text. Note

Header does not match expected text.
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (eefff5e) 79.31% compared to head (5a12561) 78.62%.

Files Patch % Lines
core/src/main/scala/fly4s/data/LoggerType.scala 50.00% 5 Missing ⚠️
core/src/main/scala-3/fly4s/data/Fly4sConfig.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   79.31%   78.62%   -0.69%     
==========================================
  Files          12       13       +1     
  Lines         406      421      +15     
  Branches        3        4       +1     
==========================================
+ Hits          322      331       +9     
- Misses         84       90       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geirolz geirolz merged commit 8ef4c60 into main Feb 12, 2024
9 of 11 checks passed
@geirolz geirolz deleted the add-loggers-configuration branch February 12, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options regarding loggers?
1 participant