Open
Conversation
contest edit fixed.
fixed clarification issues
geisler
requested changes
Jan 12, 2018
Owner
There was a problem hiding this comment.
- The permissions on
.gitignore,COPYING,README.md,Touche-Installation-Instructions.doc,develop/chroot_wrapper.c,develop/old_chroot_wrapper.c,develop/start_contest.crontab,develop/stop_contest.crontab,lib/create.inc,lib/session.inc,public_html/admin/email_body.txt,public_html/admin/rejudge.sql,public_html/admin/undo.sql,public_html/images/*,public_html/judge/Lang/Python2.inc,public_html/judge/Lang/Python3.inc,public_html/judge/errorLog.txt,public_html/judge/lib/images/*, andpublic_html/reame/inst.htmlshould stay 644 instead of changing to 755 - Lines 160 and 163 shouldn't be left in
createcontest2.php - Don't include
jail_scriptsin the repo because they are distro specific and different for each installation - I don't understand the changes to
master-crontab.cron. Why are they there? - Lines 37-39 of
public_html/admin/setup_contest.phpare broken because$iis initialized to 0 on line 111. If you move the initialization of$iearlier, this should be fixed. - Delete line 184 of
public_html/admin/setup_contest.php
geisler
requested changes
Jan 12, 2018
Owner
geisler
left a comment
geisler
left a comment
There was a problem hiding this comment.
I believe you moved the judge headers into the admin headers.
geisler
reviewed
Jan 15, 2018
Owner
geisler
left a comment
geisler
left a comment
There was a problem hiding this comment.
Lines 237-243 look incorrect as they have #1, #2, counting upward along with the print command at the end. Is this really ready to merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.