Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds strict mode around the main panel. #3830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

toddburnside
Copy link
Contributor

The strict mode is around the part of the app rendered via the ROUTER.

NOTE: This is for testing only!!! It breaks Explore.

@mergify mergify bot added the explore label May 22, 2024
Copy link

bundlemon bot commented May 22, 2024

BundleMon

Files updated (1)
Status Path Size Limits
index-(hash).js
1.63MB (-419B -0.02%) -
Unchanged files (7)
Status Path Size Limits
exploreworkers-(hash).js
602.26KB -
index-(hash).css
61.7KB -
workbox-window.prod.es5-(hash).js
2.07KB -
agsworker-(hash).js
84B -
plotworker-(hash).js
82B -
catalogworker-(hash).js
81B -
itcworker-(hash).js
75B -

Total files change -419B -0.02%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have solved the issues, I think we should have this enabled for development.

LGTM

@rpiaggio rpiaggio marked this pull request as ready for review June 28, 2024 22:59
@toddburnside
Copy link
Contributor Author

Now that we have solved the issues, I think we should have this enabled for development.

I wonder if we should put StrictMode around the entire app, not just the main panel. I just put it around the main panel because it was easy and produced the errors we had been seeing.

@rpiaggio
Copy link
Contributor

rpiaggio commented Jul 4, 2024

Now that we have solved the issues, I think we should have this enabled for development.

I wonder if we should put StrictMode around the entire app, not just the main panel. I just put it around the main panel because it was easy and produced the errors we had been seeing.

Yes, good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants