Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep sequence tile at bottom of obs tab #4476

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Keep sequence tile at bottom of obs tab #4476

merged 1 commit into from
Jan 15, 2025

Conversation

toddburnside
Copy link
Contributor

I had to give the sequence tile it's own tile controller in order to accomplish this.

@bundlemon BundleMon
Copy link

bundlemon bot commented Jan 13, 2025

BundleMon

Files updated (2)
Status Path Size Limits
✅ index-(hash).js
 1.73MB (+944B +0.05%) -
✅ index-(hash).css
 66.08KB (+65B +0.1%) -
Unchanged files (6)
Status Path Size Limits
✅ exploreworkers-(hash).js
 597.76KB -
✅ workbox-window.prod.es5-(hash).js
 2.07KB -
✅ plotworker-(hash).js
 84B -
✅ agsworker-(hash).js
 82B -
✅ catalogworker-(hash).js
 82B -
✅ itcworker-(hash).js
 81B -

Total files change +1009B +0.04%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

cquiroz
cquiroz reviewed Jan 15, 2025
View reviewed changes
explore/src/main/scala/explore/tabs/ObsTabTiles.scala
section,
props.backButton.some
),
TileController(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can't drag it to the other controller right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct.

cquiroz
cquiroz approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddburnside toddburnside merged commit 42290aa into master Jan 15, 2025
18 checks passed
@toddburnside toddburnside deleted the sc-4263-keep-sequence-tile-at-the-bottom branch January 15, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
common explore model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddburnside @cquiroz