Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShortCut 4602: Fix import dependency issue #1589

Merged
merged 1 commit into from
Jan 27, 2025
Merged

ShortCut 4602: Fix import dependency issue #1589

merged 1 commit into from
Jan 27, 2025

Conversation

swalker2m
Copy link
Contributor

Adds a FK reference from t_program(c_program_type) to t_program_type(c_type). In addition to being the right thing to do (I think), my theory is that this will cause the postgres dependency computation to order t_program_type imports before t_program imports and thereby fix the computation of program references when restoring from a backup.

@mergify mergify bot added the service label Jan 24, 2025
@swalker2m swalker2m changed the title Fix import dependency issue ShortCut 4602: Fix import dependency issue Jan 24, 2025
Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good theory. LGTM.

@swalker2m swalker2m merged commit 1f78e9d into main Jan 27, 2025
6 checks passed
@swalker2m swalker2m deleted the shortcut-4602 branch January 27, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants