Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include external authors in proposals import process #498

Merged
merged 20 commits into from
Feb 5, 2025
Merged

Include external authors in proposals import process #498

merged 20 commits into from
Feb 5, 2025

Conversation

ivan-mr
Copy link
Collaborator

@ivan-mr ivan-mr commented Nov 8, 2024

🎩 What? Why?

Include external authors (we only save the name as string) in proposals import process

📌 Related Issues

📋 Subtasks

  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Description

ivan-mr added 15 commits November 8, 2024 11:02
@ivan-mr
Include external authors in proposals import process
8a44468
@ivan-mr
Manage methods in external_author presenter
2e7fe26
@ivan-mr
Rubocop checks
7e34ee5
@ivan-mr
Merge branch 'upgrade/0.28' into feat/import_authors_proposals
0d7bbcd
@ivan-mr
Add factory and rspecs for external_authors and test for process meth…
39c43a4 
…od on proposal_creator
@ivan-mr
Merge branch 'upgrade/0.28' into feat/import_authors_proposals
9be4c8a
@ivan-mr
Merge branch 'upgrade/0.28' into feat/import_authors_proposals
687b8d7
@ivan-mr
Changes in assets csv test files to pass csv parser
3bb0d25
@ivan-mr
Add instructions on admin import proposals text to manage author names
4aa3b1f
@ivan-mr
Modifying label for external_author/name
ff160df
@ivan-mr
Merge branch 'upgrade/0.28' into feat/import_authors_proposal
49197d5
@ivan-mr
Fix index name for external_authors table
c46e989
@ivan-mr
Merge branch 'upgrade/0.28' into feat/import_authors_proposals
2fa089c
@ivan-mr
Merge branch 'upgrade/0.28' into feat/import_authors_proposals
8ee2370
@ivan-mr
Add meeting_url field on import proposal
7ac88ed
@ivan-mr ivan-mr marked this pull request as ready for review November 21, 2024 15:51
@ivan-mr ivan-mr changed the title WIP: Include external authors in proposals import process Include external authors in proposals import process Nov 21, 2024
Base automatically changed from upgrade/0.28 to master December 16, 2024 12:30
@ivan-mr ivan-mr requested a review from laurajaime January 30, 2025 08:22
@tramuntanal tramuntanal merged commit 70ef5ff into master Feb 5, 2025
6 checks passed
@tramuntanal tramuntanal deleted the feat/import_authors_proposals branch February 5, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurajaime laurajaime laurajaime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan-mr @laurajaime @tramuntanal