Fix titlebar truncation with ellipsis #630
Open
+143
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add block display to span for max-width to take effect - Apply truncate class for proper text-overflow: ellipsis - Set consistent max-width (236px) for both project and task selectors Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Set trigger span max-width to 218px to match dropdown text area width
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Keep welcome screen conditional rendering from main - Add project/task context props to Titlebar from PR branch - Maintain conditional className for main content div
Contributor
|
nice, |
- Use absolute positioning for center content to keep it truly centered - Move no-drag from wrapper divs to SelectTrigger elements - Add pointer-events-auto to SelectTriggers for clickability
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }; | ||
|
|
||
| return ( | ||
| <div className="grid w-full grid-cols-[1fr_auto_1fr] items-center"> |
There was a problem hiding this comment.
Missing pointer-events-none blocks titlebar window dragging
Medium Severity
The grid container and its child elements in TitlebarContext lack pointer-events-none, causing them to capture click/drag events. Since CSS pointer-events is not inherited, these elements default to auto despite the parent wrapper having pointer-events-none. This blocks window dragging in the titlebar area around and between the dropdown triggers, as reported in the PR discussion.
Additional Locations (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of the titlebar context controls work (commits from parent branch).
Parent branch changes (not yet merged):
This PR adds:
Before: Long task/project names were clipped without ellipsis, and truncation point differed between titlebar and dropdown
After: Names truncate with ellipsis at the same point in both places
Note
Introduces titlebar context controls and improves text truncation for long names.
TitlebarContext(project/task selectors) centered in the titlebar; plumbprojects,selectedProject,activeTask, and selection handlers fromApp→Titlebar→TitlebarContextmax-w-[218px]andtruncateto triggers and dropdown items for consistent ellipsisOpenInMenubutton styles (smaller height, adjusted typography/hover) and reduce chevron size/opacityWritten by Cursor Bugbot for commit c19b51d. This will update automatically on new commits. Configure here.