Map Shift+Enter to newline #657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: notkainoa <123281048+notkainoa@users.noreply.github.com>
…nstant Co-authored-by: notkainoa <123281048+notkainoa@users.noreply.github.com>
Co-authored-by: notkainoa <123281048+notkainoa@users.noreply.github.com>
Co-authored-by: notkainoa <123281048+notkainoa@users.noreply.github.com>
- Add !this.disposed check before ptyInput to prevent race condition - Add comprehensive test coverage for keyboard mapping logic - Tests verify Shift+Enter mapping and edge cases with modifiers Co-authored-by: notkainoa <123281048+notkainoa@users.noreply.github.com>
|
@notkainoa is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
notkainoa
changed the title
notkainoa
changed the title
Resolved merge conflicts combining: - mapShiftEnterToCtrlJ feature (HEAD) for CLI agent terminals - disableSnapshots and onLinkClick features (origin/main) for multi-chat support Conflicts resolved in: - ChatInterface.tsx - TerminalPane.tsx - SessionRegistry.ts - TerminalSessionManager.ts Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapped Shift+Enter to Ctrl+J in CLI agent terminals so Shift+Enter inserts a new line. Applies only to agent terminal view.
Fixes #636.
📝 Technical Details
Files Changed
src/renderer/terminal/TerminalSessionManager.tssrc/renderer/terminal/terminalKeybindings.ts(new)src/renderer/terminal/SessionRegistry.tssrc/renderer/components/TerminalPane.tsxsrc/renderer/components/ChatInterface.tsxsrc/renderer/components/MultiAgentTask.tsxsrc/test/renderer/TerminalSessionManager.test.ts(new)Feature: Keyboard Mapping
CTRL_J_ASCIIandshouldMapShiftEnterToCtrlJ()interminalKeybindings.tsTerminalSessionManagerwhen the flag is setTest Coverage
CTRL_J_ASCIIvalue