Delete NS and A records within an aws hosted zone.

genevieve · Jan 9, 2020 · 4322b1e · 4322b1e
1 parent 5dad352
commit 4322b1e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/aws/route53/record_sets.go b/aws/route53/record_sets.go
@@ -76,7 +76,7 @@ func (r RecordSets) DeleteAll(hostedZoneId *string, hostedZoneName string, recor
 func (r RecordSets) DeleteWithFilter(hostedZoneId *string, hostedZoneName string, records []*awsroute53.ResourceRecordSet, filter string) error {
 	var changes []*awsroute53.Change
 	for _, record := range records {
-		if strings.Contains(*record.Name, filter) && *record.Type == "A" {
+		if strings.Contains(*record.Name, filter) && (*record.Type == "A" || *record.Type == "NS") {
 			changes = append(changes, &awsroute53.Change{
 				Action:            aws.String("DELETE"),
 				ResourceRecordSet: record,

diff --git a/aws/route53/record_sets_test.go b/aws/route53/record_sets_test.go
@@ -194,6 +194,26 @@ var _ = Describe("RecordSets", func() {
 			Expect(client.ChangeResourceRecordSetsCall.Receives.ChangeResourceRecordSetsInput.ChangeBatch.Changes[0].ResourceRecordSet.Type).To(Equal(aws.String("A")))
 		})
 
+		Context("if the record set is NS type", func() {
+			BeforeEach(func() {
+				records = []*awsroute53.ResourceRecordSet{
+					{Name: aws.String(fmt.Sprintf("kiwi-%s", hostedZoneName)), Type: aws.String("A")},
+					{Name: aws.String(fmt.Sprintf("banana-%s", hostedZoneName)), Type: aws.String("NS")},
+				}
+				filter = "banana"
+			})
+
+			It("deletes the record sets that contain the filter", func() {
+				err := recordSets.DeleteWithFilter(hostedZoneId, hostedZoneName, records, filter)
+				Expect(err).NotTo(HaveOccurred())
+
+				Expect(client.ChangeResourceRecordSetsCall.CallCount).To(Equal(1))
+				Expect(client.ChangeResourceRecordSetsCall.Receives.ChangeResourceRecordSetsInput.HostedZoneId).To(Equal(hostedZoneId))
+				Expect(client.ChangeResourceRecordSetsCall.Receives.ChangeResourceRecordSetsInput.ChangeBatch.Changes[0].Action).To(Equal(aws.String("DELETE")))
+				Expect(client.ChangeResourceRecordSetsCall.Receives.ChangeResourceRecordSetsInput.ChangeBatch.Changes[0].ResourceRecordSet.Type).To(Equal(aws.String("NS")))
+			})
+		})
+
 		Context("when the client fails to delete resource record sets", func() {
 			BeforeEach(func() {
 				client.ChangeResourceRecordSetsCall.Returns.Error = errors.New("ruhroh")