Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitive Edition support and other improvements #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

heinezen
Copy link

@heinezen heinezen commented Jun 19, 2020

I made a few changes to the openage palette parser that should be useful here too 😄

  • Handling of optional fixed alpha values for the palette in line 3: $ALPHA <num>
  • Support for comments with # as seen in the modulation_colors.palx palette.
  • Empty lines are now skipped
  • Splitting with regex because values can have more than one space between them. It previously caused some colour entries containing additional NaNs.
  • New getters and setters for the new palette parameters.
  • I left the old API intact as-is.

Also, I haven't used Javascript in a while, so I hope I did not introduce some accidental errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants