Allow PHP 8.4 also #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add 8.4 to Github actions. |
|
Just realized it was missing |
|
ookay.. that code style issue might be tricker to solve without telling it to ignore PHP version |
mwikberg-virta
force-pushed
the
php-8.4
branch
from
758820a to
ea9f733
Compare
…t will fail otherwise
mwikberg-virta
force-pushed
the
php-8.4
branch
from
ea9f733 to
b174e81
Compare
|
not ideal, but nice fix |
|
Thanks for the work, created a tag too. |
|
Not ideal, no. There might be a prettier solution, but this was the simplest hack I came up with until php-cs-fixer is updated 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't spot any obvious issues running on 8.4 so far