-
Notifications
You must be signed in to change notification settings - Fork 11
docs: update claude skill and related docs #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation updates across three files: skill documentation for eval file handling and gevals command, MCP agent configuration example in README with new fields (useVirtualHome, allowedToolsJoinSeparator) and flags (--strict-mcp-config, --allowedTools), and a config struct comment reflecting the template variable naming update. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.claude/skills/create-eval/SKILL.md(2 hunks)README.md(1 hunks)pkg/agent/config.go(1 hunks)
🔇 Additional comments (3)
.claude/skills/create-eval/SKILL.md (1)
30-30: LGTM! Command rename is consistent.The command has been correctly updated from
gevals runtogevals eval, which aligns with the usage shown in README.md line 24.pkg/agent/config.go (1)
48-48: LGTM! Documentation aligned with README.The comment has been correctly updated to reference
{{ .AllowedToolArgs }}, which matches the template variable used in the README.md example (line 77). This improves consistency across the documentation.README.md (1)
72-77: LGTM! Agent configuration example updated correctly.The agent.yaml example has been enhanced with:
useVirtualHome: false- matches the struct field in config.go line 30allowedToolsJoinSeparator: ","- matches the struct field in config.go line 43- Updated
runPromptwith new flags--strict-mcp-configand--allowedTools "{{ .AllowedToolArgs }}"- aligns with the comment in config.go line 48These changes properly document the new configuration options and demonstrate their usage.
Cali0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @schuellerf !
|
|
||
| ```bash | ||
| gevals run <path to eval yaml file> | ||
| gevals eval <path to eval yaml file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, forgot to update this when we added #19
On that note, would you mind adding a line here explaining the -run flag? I'm assuming a lot of the time, claude will want to run only a subset of an eval suite
Update claude skill and related docs
I tried to align README, code and claude skill
Please check thoroughly if I understood the config correctly
Summary by CodeRabbit
Documentation
Configuration