-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
299 add qc for nanopore data #344
base: master
Are you sure you want to change the base?
Conversation
…icine-sweden/jasen into 299-add-qc-for-nanopore-data confusion with committing
Confusion with commits, need to check what happened before reviewing and merging |
No worries, make it a draft until you're ready for review, so we don't use the CI resources:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know most of my comments are due to merging master and resolving conflict errors. Otherwise it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change, needs to be tested!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Added module with NanoPlot to check quality of raw input reads produced by ONT technology.
Summary of the changes made:
added new module script, added container URL to Makefile, changed bacterial base workflow script
Primary function of PR
Testing
The pipeline has been run with test data, NanoPlot report is produced in the nanoplot output folder.
Sign-offs