Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

299 add qc for nanopore data #344

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

Emkago
Copy link
Contributor

@Emkago Emkago commented Sep 9, 2024

Description

Added module with NanoPlot to check quality of raw input reads produced by ONT technology.

Summary of the changes made:
added new module script, added container URL to Makefile, changed bacterial base workflow script

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

The pipeline has been run with test data, NanoPlot report is produced in the nanoplot output folder.

Sign-offs

@Emkago Emkago requested a review from a team as a code owner September 9, 2024 07:49
@Emkago Emkago linked an issue Sep 9, 2024 that may be closed by this pull request
@Emkago
Copy link
Contributor Author

Emkago commented Sep 9, 2024

Confusion with commits, need to check what happened before reviewing and merging

@ryanjameskennedy
Copy link
Collaborator

No worries, make it a draft until you're ready for review, so we don't use the CI resources:)

@Emkago Emkago marked this pull request as draft September 9, 2024 09:08
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know most of my comments are due to merging master and resolving conflict errors. Otherwise it looks good!

@Emkago Emkago marked this pull request as ready for review November 22, 2024 07:53
@Emkago Emkago marked this pull request as draft November 22, 2024 07:54
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change, needs to be tested!

@Emkago Emkago marked this pull request as ready for review December 20, 2024 09:46
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add QC for Nanopore data
2 participants