fix: use dynamic imports for optional ffmpeg dependencies#62
Merged
Conversation
…encies Move @ffmpeg/ffmpeg and @ffmpeg/util from top-level static imports to dynamic imports inside the load() function. Since these are optional peer dependencies, static imports cause resolution errors for consumers who don't have them installed. The FFmpeg instance and fetchFile function are now stored in closure variables so other methods like convert() can still access them after load() completes. Includes comprehensive test coverage for dynamic import behavior, progress tracking, command construction, and file cleanup. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Move useFFMpeg import to top of test file to satisfy import/first rule and correct the video-compressor docs to show the actual composable API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
genu
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ffmpeg/ffmpegand@ffmpeg/utilfrom static top-level imports to dynamicimport()calls insideload()fetchFilefunction are stored in closure variables for access by other methodsChanges
load()methodAll 380 tests pass.