PB-1383: External layers not loaded at startup

[ltkum]

Issue: When trying to access the app, if there were external layers, they wouldn't be taken into account and not loaded.

Fix: We remove a check that bypassed the addition of layers to the store at startup.

Test link

[cypress]

web-mapviewer    Run #6029

Run Properties:   Failed #6029  •  6824f36df0: PB-1383: External layers not loaded at startup

Project	web-mapviewer
Branch Review	fix-PB-1383-external-layers-in-url
Run status	Failed #6029
Run duration	11m 41s
Commit	6824f36df0: PB-1383: External layers not loaded at startup
Committer	Martin Künzi
View all properties for this run ↗︎

---

Test results
Failures	52
Flaky	0
Pending	19
Skipped	0
Passing	113
View all changes introduced in this branch ↗︎

---

Tests for review

  drawing.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

  timeSlider.cy.ts • 3 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly part 1		Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly with the timeSlider param at startup		Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > behaves correctly when years are being entered in the input		Test Replay Screenshots

  layers.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

  3d/layers.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

  legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
An uncaught error was detected outside of a test		Test Replay Screenshots

The first 5 failed specs are shown, see all 26 specs in Cypress Cloud.

[pakb]

Can you also check a small bug I've seen while testing:

If you change the opacity of an external layer, then reload, the opacity is correctly applied only before the layer loads. It looks like the "after-load" actions are overwriting the opacity in the URL and set it back to the default value

[ltkum]

Can you also check a small bug I've seen while testing:

If you change the opacity of an external layer, then reload, the opacity is correctly applied only before the layer loads. It looks like the "after-load" actions are overwriting the opacity in the URL and set it back to the default value

This should be done with the following PR, I encountered the same bug while trying to fix the layers e2e tests. #1509